cargo-crev: 0.16.1 -> 0.17.0 #95667
Merged
cargo-crev: 0.16.1 -> 0.17.0 #95667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
cargo-crev-0.17.0
branch
from
dd3cdf9
to
2efb6ad
Compare
danieldk
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 95667 1
1 package built:
- cargo-crev
Binary works: ✔️
The formatting of the arguments was getting a bit wonky, so I ran nixpkgs-fmt on the derivation.
Let's see if ofborg is still happy and then merge.
|
@ofborg build cargo-crev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates
cargo-crevto the latest release.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)