Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-release: fix darwin build #95634

Merged
merged 1 commit into from Aug 18, 2020
Merged

cargo-release: fix darwin build #95634

merged 1 commit into from Aug 18, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 17, 2020

Motivation for this change

Noticed that is wasn't building on darwin.

https://hydra.nixos.org/build/125179215/nixlog/1/tail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 17, 2020
@ofborg ofborg bot requested a review from Gerschtli August 17, 2020 01:31
@dywedir
Copy link
Member

dywedir commented Aug 18, 2020

Thanks!

@dywedir dywedir merged commit c567636 into NixOS:master Aug 18, 2020
@zowoq zowoq deleted the cargo-release branch August 18, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @dywedir