Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pylint-django: 2.1.0 -> 2.3.0, run tests #95672

Merged
merged 2 commits into from Aug 17, 2020
Merged

python3Packages.pylint-django: 2.1.0 -> 2.3.0, run tests #95672

merged 2 commits into from Aug 17, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Aug 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kamadorueda August 17, 2020 10:55
jonringer
jonringer approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
failures on target branch

https://github.com/NixOS/nixpkgs/pull/95672
1 package failed to build:
prospector

2 packages built:
python37Packages.pylint-django python38Packages.pylint-django

@jonringer jonringer merged commit 8d9f9fd into NixOS:master Aug 17, 2020
@maxxk maxxk deleted the pylint-django-2.3 branch August 17, 2020 17:11
@maxxk
Copy link
Contributor Author

maxxk commented Aug 17, 2020

Thanks!

Prospector is broken due to pyflakes and astroid version mismatch.
Current version of prospector (1.3.0) requires astroid == 2.4.1, nixpkgs has 2.4.2, so unfortunately we can't update yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxxk @jonringer