Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sogo: 4.3.2 -> 5.0.0 #95678

Merged
merged 4 commits into from Aug 25, 2020
Merged

sogo: 4.3.2 -> 5.0.0 #95678

merged 4 commits into from Aug 25, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 17, 2020

Motivation for this change

New upstream release.

cc @herrwiese @dasJ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dasJ
dasJ approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, currently running this in production

@ofborg ofborg bot requested a review from dasJ August 17, 2020 11:48
@ajs124
sogo: switch to (hopefully) stable patch url
6ba9e9c 
patches were "rewritten" in their repo, that's why the hash changed
@ajs124
Copy link
Member Author

ajs124 commented Aug 25, 2020

cc @Lassulus

@Lassulus Lassulus merged commit e357d0e into NixOS:master Aug 25, 2020
@ajs124 ajs124 deleted the upd/sogo branch August 25, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @dasJ @Lassulus