Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonts.fontconfig-penultimate: remove dependency on fontconfig_210 #95677

Closed
wants to merge 1 commit into from
Closed

fonts.fontconfig-penultimate: remove dependency on fontconfig_210 #95677

wants to merge 1 commit into from

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Aug 17, 2020

Motivation for this change

Since #93562 was merged,
configurations which set fonts.fontconfig.penultimate.enable to true
will fail to build, tripping the assertion:

fontconfig 2.10.x hasn't had a release in years, is vulnerable to CVE-2016-5384
and has only been used for old fontconfig caches.

This rectifies the module, deleting references to fontconfig_210. I just
did the most obvious thing possible to make it build, and didn't really
think properly about the consequences, so I would appreciate some review
on this one from someone who knows the fontconfig stuff a bit better.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu NickHu requested review from jtojnar and ttuegel August 17, 2020 10:57
@flokli
Copy link
Contributor

flokli commented Aug 17, 2020

I wonder if we should keep penultimate at all: #92571 (comment)

@flokli
Copy link
Contributor

flokli commented Aug 17, 2020

I opened #95681 removing fontconfig-pentultimate.

@NickHu
Copy link
Contributor Author

NickHu commented Aug 17, 2020

Ah, I didn't realise that upstream fontconfig-penultimate hasn't been updated in over 3 years. I guess what you propose makes more sense.

@NickHu NickHu closed this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@ttuegel ttuegel Awaiting requested review from ttuegel

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickHu @flokli