Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: update all versions to 1.0.0 #95655

Merged
merged 1 commit into from Aug 18, 2020
Merged

factorio: update all versions to 1.0.0 #95655

merged 1 commit into from Aug 18, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Aug 17, 2020 •
edited

Motivation for this change

factorio 1.0.0 was released: https://factorio.com/blog/post/fff-360

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Aug 17, 2020
View reviewed changes
pkgs/games/factorio/default.nix
};
demo = {
stable = bdist { sha256 = "07qknasaqvzl9vy1fglm7xmdi7ynhmslrb0a209fhbfs0s7qqlgi"; version = "0.17.79"; };
stable = bdist { sha256 = "0h9cqbp143w47zcl4qg4skns4cngq0k40s5jwbk0wi5asjz8whqn"; version = "1.0.0"; };
};
};
i686-linux = let bdist = bdistForArch { inUrl = "linux32"; inTar = "i386"; }; in {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the update of i686-linux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, the commit comment suggests that all versions are updated to 1.0.0 but 0.14.23 is the latest 32bit version, see https://factorio.com/download/archive.

I will adjust the commit message.

@ofborg ofborg bot requested review from Baughn, erictapen and elitak August 17, 2020 07:24
@jonringer
Copy link
Contributor

that's awkward, I was already doing then, and just wanted to make sure I wasn't duplicating PR before hitting submit. But you got the same hashes I did. So... looks good to me

jonringer
jonringer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/95655
3 packages built:
factorio factorio-demo factorio-headless

@jonringer jonringer merged commit 1628643 into NixOS:master Aug 18, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/factorio-community-server/8622/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@jonringer jonringer jonringer approved these changes

@Baughn Baughn Awaiting requested review from Baughn

@erictapen erictapen Awaiting requested review from erictapen

@elitak elitak Awaiting requested review from elitak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@priegger @jonringer @nixos-discourse @prusnak