Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] mesos: 1.4.1 -> 1.10.0 #95631

Closed
wants to merge 1 commit into from
Closed

[WIP] mesos: 1.4.1 -> 1.10.0 #95631

wants to merge 1 commit into from

Conversation

ludovicc
Copy link

Motivation for this change

Upgrade Mesos from 1.4.1 to 1.10.0, fix this package broken since Dec 2019 and a dependency of Spark.

Need help to complete the packaging.

Things done
  • refreshed nixos patch
  • currently autoconfigure checks failing
checking google/protobuf/map.h usability... yes
checking google/protobuf/map.h presence... yes
checking for google/protobuf/map.h... yes
checking for /nix/store/ayiyc1a33cddxbgvrjhqh152inncbcn5-protobuf-3.6.1.3/include/google/protobuf/wrappers.proto... yes
checking for protoc... protoc
checking python2 module: google.protobuf... no
configure: error: failed to find required module google.protobuf
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ludovicc
Copy link
Author

@cstrahan can you help me to complete this upgrade? Thanks

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/33

jonringer
jonringer reviewed Aug 17, 2020
View reviewed changes
pkgs/applications/networking/cluster/mesos/default.nix
};

patches = [
# https://reviews.apache.org/r/36610/
# TODO: is this still needed?
./rb36610.patch

# see https://github.com/cstrahan/mesos/tree/nixos-${version}
# see https://github.com/ludovicc/mesos/tree/nixos-${version}
./nixos.patch
];
nativeBuildInputs = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to solve your immediate issue

Suggested change
nativeBuildInputs = [
nativeBuildInputs = [
python2.pkgs.protobuf

@flokli
Copy link
Contributor

flokli commented Aug 17, 2020 •
edited

mesos, chronos and marathon have been removed in #95507, so this PR needs to be rebased onto master. Please also update the maintainers attribute to reflect the current situation, and re-introduce the tests (in python) while doing so.

@flokli
Copy link
Contributor

flokli commented Sep 5, 2020

What's the status of this? Can this be rebased to latest master, as written in #95631 (comment)?

@ryantm ryantm marked this pull request as draft October 23, 2020 02:59
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@siraben siraben closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ludovicc @nixos-discourse @flokli @jonringer @ryantm @siraben