Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-bindgen: 0.53.2 -> 0.54.1 #95630

Merged
merged 1 commit into from Aug 17, 2020
Merged

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Aug 16, 2020

Motivation for this change

The bot has tried to update this to 0.54.0 but seems no one has reviewed it yet: #89015
This is used as a library generally but the command line usage is also useful for some purposes. As a libc crate's maintainer, I'd like to update it and help maintain.
Closes #89015

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 95630 1

1 package built:
- rust-bindgen

Binary works as expected.

@danieldk danieldk merged commit 078b9f8 into NixOS:master Aug 17, 2020
@JohnTitor JohnTitor deleted the rust-bindgen-0.54.1 branch August 17, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants