Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-han-*: reduce closure size by 2x #95701

Merged
merged 1 commit into from Aug 18, 2020
Merged

source-han-*: reduce closure size by 2x #95701

merged 1 commit into from Aug 18, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Aug 17, 2020

The file name of the installed font was the path returned by fetchurl:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-SourceHanSans.ttc

This caused the derivation to reference the downloaded font file,
storing the font twice unless you optimise the store (each file is
~150M).

cc maintainers @taku0 @emilazy

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)

馃槃 Determined the impact on package closure size (by running nix path-info -S before and after)

@gebner
source-han-*: reduce closure size by 2x
9fb2c88 
The file name of the installed font was the path returned by fetchurl:
`xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-SourceHanSans.ttc`

This caused the derivation to reference the downloaded font file,
storing the font twice unless you optimise the store (each file is
~150M).
@ofborg ofborg bot requested review from emilazy and taku0 August 17, 2020 17:52
@gebner gebner merged commit 08639bc into NixOS:master Aug 18, 2020
@linsui linsui mentioned this pull request Sep 28, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @taku0