applet.interface.uart: allow to invert the UART line signals (=idle low) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd probably use two arguments, |
That was the other option I was considering. I can change it. Did you look at the other code? |
|
The code is basically fine I think. |
Adds the --invert-rx and --invert-tx cli arguments and the corresponding build-time parameters to the uart gateware.
electroniceel
force-pushed
the
uart-invert
branch
from
f9f6f70
to
66d8817
Compare
|
Ok, new arguments implemented. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --invert {RX,TX,RXTX,both,none} cli argument and the corresponding
build-time parameters to the uart gateware.
This option comes in handy when driving UART through inverting optocouplers for example.
@whitequark sorry, I haven't done a conversion to nMigen of the module. I don't have confidence in my (n)Migen skills enough for this.