Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi 2.6.1 -> 2.8.2 #95619

Closed
wants to merge 1 commit into from

Conversation

MasseGuillaume
Copy link
Contributor

modules
aws: 2.13.0 -> 3.1.0
gcp: 3.13.0 -> 3.18.0
kubernetes: 2.4.0 -> 2.4.3
postgresql: 2.2.2 -> 2.3.0

Motivation for this change

update to current latest versions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

modules
aws:        2.13.0 -> 3.1.0
gcp:        3.13.0 -> 3.18.0
kubernetes: 2.4.0  -> 2.4.3
postgresql: 2.2.2  -> 2.3.0
@ludovicc
Copy link

ludovicc commented Sep 1, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin 19.05
  • executables tested on Darwin
  • all depending packages build
Possible improvements
Comments

pulumi 2.9.2 is already available... Hard to keep up

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

Builds and runs on NixOS, did not test function.

@mudrii
Copy link
Contributor

mudrii commented Nov 27, 2020

I think we can close this PR as a new updated version is available #105010.

@cpcloud
Copy link
Contributor

cpcloud commented Jan 8, 2021

This can be closed in light of #108814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants