Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.containers: 2.7 -> 3.0 #95648

Closed
wants to merge 1 commit into from
Closed

Conversation

kwshi
Copy link

@kwshi kwshi commented Aug 17, 2020

Motivation for this change

Updates OCaml containers to latest release, which offers useful new features and a more consistent API. Contains some API breaking changes (that are easy to fix; mostly just renamed functions).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Aug 17, 2020

@GrahamcOfBorg build ocamlPackages.tsort

@vbgl
Copy link
Contributor

vbgl commented Aug 24, 2020

Subsumed by #95649

@vbgl vbgl closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants