Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGo{Module,Package} packages: remove enableParallelBuilding = true #95639

Merged
merged 7 commits into from Aug 17, 2020
Merged

buildGo{Module,Package} packages: remove enableParallelBuilding = true #95639

merged 7 commits into from Aug 17, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 17, 2020

enableParallelBuilding defaults to true.

# We want parallel builds by default
, enableParallelBuilding ? true

# We want parallel builds by default
, enableParallelBuilding ? true

@zowoq zowoq requested review from kalbasit and Mic92 August 17, 2020 02:30
@zowoq
Copy link
Contributor Author

zowoq commented Aug 17, 2020

Do we even need a enableParallelBuilding option for buildGo{Module,Package}?

Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mic92
Copy link
Member

Mic92 commented Aug 17, 2020

Do we even need a enableParallelBuilding option for buildGo{Module,Package}?

It does not have an effect, but maybe it should: #95595 Right now I don't see a use-case for it though. The ecosystem is mostly fine with parallel builds.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 17, 2020

Opened a PR #95657

@zowoq zowoq merged commit cb02aa3 into NixOS:master Aug 17, 2020
@zowoq zowoq deleted the go-parallel branch August 17, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants