Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-fund: init at 0.2.0 #95628

Merged
merged 1 commit into from Aug 17, 2020
Merged

cargo-fund: init at 0.2.0 #95628

merged 1 commit into from Aug 17, 2020

Conversation

JohnTitor
Copy link
Member

Motivation for this change

cargo-fund is a helpful cargo subcommand binary to support FLOSS developers.
https://github.com/acfoltzer/cargo-fund

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Already looks very good. Some very small comments to make the derivation even more canonical.

pkgs/development/tools/rust/cargo-fund/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rust/cargo-fund/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rust/cargo-fund/default.nix Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member Author

Thanks for reviewing! Addressed all the points.

danieldk
danieldk approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

Result of nixpkgs-review pr 95628 1

1 package built:
- cargo-fund

@danieldk
Copy link
Contributor

@ofborg build cargo-fund

@danieldk danieldk merged commit e983686 into NixOS:master Aug 17, 2020
@JohnTitor JohnTitor deleted the init-cargo-fund branch August 17, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnTitor @danieldk