vr-video-player and openvr init #95627
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanloutre
force-pushed
the
vr-video-player
branch
from
b9a699e
to
03fbc89
Compare
|
@ofborg build vr-video-player |
SuperSandro2000
requested changes
Jan 18, 2021
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
nyanloutre
force-pushed
the
vr-video-player
branch
from
35d0186
to
5e93617
Compare
stale
bot
removed
the
2.status: stale
| is under SteamVR in Tools on Steam. | ||
| ''; | ||
| license = licenses.bsd3; | ||
| homepage = "http://steamvr.com"; |
There was a problem hiding this comment.
Suggested change
| homepage = "http://steamvr.com"; | |
| homepage = "https://www.steamvr.com/"; |
| }) | ||
| ]; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ cmake pkgconfig ]; | |
| nativeBuildInputs = [ cmake pkg-config ]; |
Comment on lines
+40
to
+42
| --add-flags $out/bin/.vr-video-player | ||
|
|
||
| ''; |
There was a problem hiding this comment.
Suggested change
| --add-flags $out/bin/.vr-video-player | |
| ''; | |
| --add-flags $out/bin/.vr-video-player | |
| ''; |
| sha256 = "sha256-gkpncA/r/Vw/OZrqBWxyJw1y96OhTGVgtcj0+g0dTCc="; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ |
There was a problem hiding this comment.
Please correctly split nativeBuildInputs and buildInputs.
| buildPhase = '' | ||
| substituteInPlace src/main.cpp \ | ||
| --replace "config/hellovr_actions.json" "$out/config/hellovr_actions.json" | ||
| ./build.sh |
There was a problem hiding this comment.
Suggested change
| ./build.sh | |
| # shellfile with calls the compiler direct | |
| ./build.sh |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There still is a problem with the https://git.dec05eba.com/vr-video-player git repository, so I made this a draft PR.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)