Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fonts: remove fontconfig-penultimate #95681

Merged
merged 2 commits into from Aug 17, 2020
Merged

nixos/fonts: remove fontconfig-penultimate #95681

merged 2 commits into from Aug 17, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 17, 2020

Motivation for this change

fontconfig-penultimate was a minimalistic fork of the abandoned fontconfig-ultimate. It also hasn't received any updates in the last 3 years. With fontconfig being in much better shape these days, there's no need to keep it.

#92571 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Aug 17, 2020
Closed
Closed
@flokli
Copy link
Contributor Author

flokli commented Aug 17, 2020

@ttuegel any opinions?

@infinisil infinisil merged commit c6aa9e4 into NixOS:master Aug 17, 2020
@infinisil
Copy link
Member

Sounds very reasonable :)

@worldofpeace
Copy link
Contributor

Yep, I was planning to do this after we already removed fontconfig-ultimate. But I think we should add a mention in the release notes for 20.09.

@infinisil
Copy link
Member

In this case I don't think we need a release notes entry, because an explanatory error is already being thrown if people used it before. Imo release notes are only necessary for things we can't have nice warnings/errors for.

evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Aug 19, 2020
@evanjs
disable penultimate
deb8079 
penultimate has been removed
see NixOS/nixpkgs#95681 for more information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickHu NickHu NickHu approved these changes

@jtojnar jtojnar jtojnar approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@infinisil infinisil Awaiting requested review from infinisil

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @infinisil @worldofpeace @NickHu @jtojnar