Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.svglib: init at 1.0.0 #95632

Merged
merged 2 commits into from Aug 17, 2020
Merged

python3Packages.svglib: init at 1.0.0 #95632

merged 2 commits into from Aug 17, 2020

Conversation

trepetti
Copy link
Contributor

Motivation for this change

svglib is a pure Python package for manipulating and exporting SVGs. Due to its focus on portability, it has already seen use in an academic molecular dynamics package and a tool for generating gcode from PCB Gerber files for CNC fabrication. The latter of which, FlatCAM, I am in the process of packaging, and for which I am submitting this last remaining requirement as a stepping stone.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 17, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

should be only two commits:

maintainers: add <name>
python3Packages.svglib: init at 1.0.0

@trepetti
Copy link
Contributor Author

should be only two commits:

maintainers: add <name>
python3Packages.svglib: init at 1.0.0

After an initial rebase misfire, I think these two reorganized commits should do the trick. Thank you for your review.

jonringer
jonringer approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95632 1

2 packages built:
- python37Packages.svglib
- python38Packages.svglib

@jonringer jonringer merged commit 1b9acad into NixOS:master Aug 17, 2020
@trepetti trepetti deleted the svglib branch August 22, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trepetti @jonringer @Janik-Haag