Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idris2: Enable --install, bugfixes #95643

Closed
wants to merge 460 commits into from

Conversation

wchresta
Copy link
Member

This removes the need of the bin/idris2_app folder
and replaces it with proper links to the nix-storage folders
This also allows the user to override IDRIS2_PREFIX which
will allow them to use --install to install libraries.

  • Fix: idris2_app/ was exposed in bin/
  • Remove native Idris2 wrapper that set LD_LIBRARY_PATH
  • Improve new Idris2 wrapper to set Idris2 paths to out folders
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wchresta
Copy link
Member Author

@GrahamcOfBorg build idris2

@wchresta
Copy link
Member Author

wchresta commented Aug 17, 2020

Conflicts with #95640 going to revise this once 0.2.1 is merged.

onsails and others added 23 commits August 17, 2020 18:37
Installation includes the the captured compilation settings in the
outputs, and the full gcc path then leads to a bogus runtime
dependency. To defeat this, we remove any occurrences of the
compiler's store dir prefix from this file after installation.
```
  Processing ./bip_utils-1.0.5-py2-none-any.whl
  ERROR: Package 'bip-utils' requires a different Python: 2.7.18 not in '>=3.6'
```
```
  Processing ./sphinxcontrib_applehelp-1.0.2-py2.py3-none-any.whl
  ERROR: Package 'sphinxcontrib-applehelp' requires a different Python: 2.7.18 not in '>=3.5'
```
```
  Processing ./sphinxcontrib_htmlhelp-1.0.3-py2.py3-none-any.whl
  ERROR: Package 'sphinxcontrib-htmlhelp' requires a different Python: 2.7.18 not in '>=3.5
```
```
  Processing ./sphinxcontrib_serializinghtml-1.1.4-py2.py3-none-any.whl
  ERROR: Package 'sphinxcontrib-serializinghtml' requires a different Python: 2.7.18 not in '>=3.5'
```
@wchresta
Copy link
Member Author

ARGH

@wchresta wchresta closed this Aug 17, 2020
@wchresta wchresta deleted the idris2-path-fixes branch August 17, 2020 22:48
@jonringer
Copy link
Contributor

I think you pushed the wrong branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet