Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitpert: init at 0.0.7 #95641

Closed
wants to merge 2 commits into from
Closed

gitpert: init at 0.0.7 #95641

wants to merge 2 commits into from

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 17, 2020 •
edited

Motivation for this change

https://github.com/augmentable-dev/gitpert/tree/v0.0.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Please change title to something like gitpert: init at VERSION for readability. Add comments about what was lacking in pet package (other than "redundant"). It looks like pet should be a different PR b/c it's not on-topic for gitpert at all.

SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/development/tools/pet/default.nix
@@ -13,15 +13,10 @@ buildGoModule rec {

vendorSha256 = "0pnd89iqdj3f719xf4iy5r04n51d0rrrf0qb2zjirpw7vh7g82i9";

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@Mindavi
Copy link
Contributor

Mindavi commented Apr 24, 2022

Upstream doesn't seem very maintained and the PR author doesn't seem interested in maintaining this (no response even though a comment was given the day after the PR was created). Please make a new PR (or reopen) if you're still interested in this.

@Mindavi Mindavi closed this Apr 24, 2022
@Mindavi Mindavi changed the title Opensource/nixpkgs/init/gitpert gitpert: init at 0.0.7 Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalbasit @drewrisinger @Mindavi @SuperSandro2000