Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-shell: 3.36.4 -> 3.36.5 #95694

Merged
merged 1 commit into from Aug 23, 2020
Merged

gnome-shell: 3.36.4 -> 3.36.5 #95694

merged 1 commit into from Aug 23, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Aug 17, 2020 •
edited by jtojnar

Motivation for this change

Version bump.
Release news:

3.36.5

  • Fix extension updates when many extensions are installed [Jeremias; !1363]
  • Fix missing icons in on-screen keyboard [Emre; #2631, #3007]
  • Fix delay when showing calendar events [Sebastian; #2992]
  • Fix app picker regressions on small displays [Sebastian; #2234, !1375, !1378]
  • Fix top bar navigation when NumLock is active [Olivier; #550]
  • Delay login animation until wallpaper has loaded [Michael; #734996]
  • Revert changes that caused mispositioning in overview in multi-monitor setups
    [Robert; #2971]
  • Reset auth prompt on login screen on VT switch before fade in [Ray; #2997]
  • Fix stuck grab when destroying open popup menu [Florian; #3022]
  • Misc. bug fixes and cleanups [Florian, Carlos, Andre, Jonas; !1357, !1371,
    !1381, #3037, #3005, !1386, !1390]

Contributors:
Michael Catanzaro, Jonas Dreßler, Olivier Fourdan, Carlos Garnacho,
Sebastian Keller, Robert Mader, Andre Moreira Magalhaes, Florian Müllner,
Jeremias Ortega, Ray Strode, Emre Uyguroglu

Translators:
Boyuan Yang [zh_CN], Rafael Fontenelle [pt_BR]

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 17, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 17, 2020 •
edited

@GrahamcOfBorg test gnome3 gnome3-xorg

repeat

@worldofpeace
Copy link
Contributor

@dasj19 I'm noticing alot of your commit messages are missing the gnome3 attribute. I believe for package updates it's important that the attribute is always buildable. I do understand it's a bit confusing since we haven't moved all of gnome to toplevel yet 😁

@dasj19
Copy link
Contributor Author

dasj19 commented Aug 21, 2020

@dasj19 I'm noticing alot of your commit messages are missing the gnome3 attribute. I believe for package updates it's important that the attribute is always buildable. I do understand it's a bit confusing since we haven't moved all of gnome to toplevel yet grin

Okay, I'll keep that in mind for the next time.

hedning
hedning approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the gnome3 test locally with gnome-shell 3.36.5 (with a fix which should hopefully make the test more stable). Should be fine :)

@hedning hedning merged commit 2ca6f6d into NixOS:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasj19 @jtojnar @worldofpeace @hedning