Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGo{Module,Package}: remove enableParallelBuilding #95657

Closed
wants to merge 2 commits into from
Closed

buildGo{Module,Package}: remove enableParallelBuilding #95657

wants to merge 2 commits into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq mentioned this pull request Aug 17, 2020
Merged
@flokli
Copy link
Contributor

flokli commented Aug 17, 2020

Please add a comment in the commit messages explaining the reasoing.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 24, 2020

Will probably look at this again in a few months, I'll wait to see if we end up adding a similar option to rust or not.

@zowoq zowoq closed this Aug 24, 2020
@zowoq zowoq deleted the go-builder-parallel branch August 24, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @flokli