ansible: 2.9.12 -> 2.10.0; ansible_2_7: drop #95683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 17, 2020
There was a problem hiding this comment.
actions LGTM
However, it appears that ansible_2_10 no longer installs the "ansible" module, and instead just installs "ansible_base". Not sure if this is an upstream bug, but it breaks all of the other ansible packages
https://github.com/NixOS/nixpkgs/pull/95683
7 packages failed to build:
ansible-lint python27Packages.pytest-ansible python37Packages.ansible-kernel python37Packages.ansible-lint python37Packages.pytest-ansible python38Packages.ansible-kernel python38Packages.pytest-ansible
7 packages built:
ansible ansible_2_9 kargo python27Packages.ansible python37Packages.ansible python37Packages.ansible-runner python38Packages.ansible-runner
ansible 2.10 site-packages:
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-95683]$ ls ./results/ansible/lib/python3.8/site-packages/ansible
ansible/ ansible_base-2.10.0.dist-info/ ansible_test/
|
This appears to have been intentional: ansible/ansible@2268a37#diff-2eeaed663bd0d25b7e608891384b7298 I would say, keep the 2.9 version in |
|
Updated. |
jonringer
reviewed
Aug 21, 2020
Comment on lines
24
to
28
| owner = "ansible"; | ||
| repo = "ansible"; | ||
| rev = "v${version}"; | ||
| sha256 = "0c794k0cyl54807sh9in0l942ah6g6wlz5kf3qvy5lhd581zlgyb"; | ||
| sha256 = "0k9rs5ajx0chaq0xr1cj4x7fr5n8kd4y856miss6k01iv2m7yx42"; | ||
| }; |
There was a problem hiding this comment.
the hash needs to be reverted, still pointing to 2_10
This version went EOL on 2020/06/18.
jonringer
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/ansible/ansible/blob/v2.10.0/changelogs/CHANGELOG-v2.10.rst#v2-10-0
Dropping 2.7 as per https://access.redhat.com/support/policy/updates/ansible-engine. I thought we had time until v2.10.0 was released, as the EOL previously was given as:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)