Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idris2: 0.2.0 -> 0.2.1 #95640

Merged
merged 1 commit into from Aug 18, 2020
Merged

idris2: 0.2.0 -> 0.2.1 #95640

merged 1 commit into from Aug 18, 2020

Conversation

valencik
Copy link
Contributor

Motivation for this change

Updating idris2 to latest version 0.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

\cc @bcdarwin

@ofborg ofborg bot requested a review from wchresta August 17, 2020 03:33
@wchresta wchresta mentioned this pull request Aug 17, 2020
Closed
10 tasks
bcdarwin
bcdarwin approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit looks fine; results of nixpkgs-review:

1 package built:
idris2

wchresta
wchresta approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@wchresta wchresta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checksum looks fine.
Successfully built in NixOS, binaries work
LGTM - Thank you 👍

@valencik
Copy link
Contributor Author

I think we're all reviewed and ready to roll, just need someone with permissions to merge.

pinging @veprbl and @Lassulus (as they've merged previous idris2 PRs)

@Lassulus Lassulus merged commit feb9c28 into NixOS:master Aug 18, 2020
@valencik valencik deleted the idris21 branch August 19, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@wchresta wchresta wchresta approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valencik @bcdarwin @wchresta @Lassulus