Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci-seccomp-bpf-hook: new at 1.2.0 #95662

Merged
merged 1 commit into from Aug 21, 2020
Merged

oci-seccomp-bpf-hook: new at 1.2.0 #95662

merged 1 commit into from Aug 21, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 17, 2020 •
edited

Motivation for this change

Add a new package for the OCI seccomp BPF hook package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/podman

@saschagrunert saschagrunert force-pushed the oci-seccomp-bpf-hook branch 2 times, most recently from 23bc336 to 6fcc921 Compare August 19, 2020 07:04
@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

@ofborg build oci-seccomp-bpf-hook

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

@saschagrunert Do you want to try fixing aarch64 build failure before we merge? If not I'm fine with just disabling the package on aarch64.

@saschagrunert
Copy link
Member Author

@saschagrunert Do you want to try fixing aarch64 build failure before we merge? If not I'm fine with just disabling the package on aarch64.

Hm yeah let's exclude it for now. I check if I can fix this in the upstream sources.

@saschagrunert
Copy link
Member Author

@ofborg build oci-seccomp-bpf-hook

@saschagrunert
oci-seccomp-bpf-hook: new at 1.2.0
b59e7c0 
Add a new package for the OCI seccomp BPF hook package.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

@ofborg build oci-seccomp-bpf-hook

@zowoq zowoq merged commit e48ddd2 into NixOS:master Aug 21, 2020
@saschagrunert saschagrunert deleted the oci-seccomp-bpf-hook branch August 21, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @zowoq