Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipmenu: 6.0.1 -> 6.1.0 #94085

Merged
merged 5 commits into from Aug 4, 2020
Merged

clipmenu: 6.0.1 -> 6.1.0 #94085

merged 5 commits into from Aug 4, 2020

Conversation

xaverh
Copy link
Contributor

@xaverh xaverh commented Jul 28, 2020

Motivation for this change

Upstream provided an update (v 6.1.0), also there's now an upstream Makefile.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverh
clipmenu 6.0.1 → 6.1.0
5a0c05e
@xaverh
Use upstream Makefile
cafe0e2 
Since v 6.1 upstream provides a Makefile, therefore I removed the install steps in `installPhase`.
@ofborg ofborg bot requested a review from jb55 July 28, 2020 15:18
@xaverh @sikmir
Update pkgs/applications/misc/clipmenu/default.nix
f8e6546 
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
@ofborg ofborg bot requested a review from jb55 July 30, 2020 09:27
@Mic92 Mic92 mentioned this pull request Jul 31, 2020
Merged
@magnetophon
Copy link
Member

Works perfectly here, including fzf integration.

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2020

Result of nixpkgs-review pr 94085 1

1 package built:
- clipmenu

@Mic92 Mic92 merged commit 10649af into NixOS:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@sikmir sikmir sikmir left review comments

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xaverh @magnetophon @Mic92 @jb55 @sikmir @Janik-Haag