Stream NARs from the remote to the destination store #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake input changes: * Updated 'nix': 'github:NixOS/nix/1ab9da915422405452118ebb17b88cdfc90b1e10' -> 'github:NixOS/nix/d7c0f094cbcfe1ae4ccc3d54baec00b66ccb1ed0'
SHA-1 is deprecated and it will be expensive to compute with the streaming NAR handler.
grahamc
reviewed
Jul 27, 2020
Ericson2314
reviewed
Jul 27, 2020
Comment on lines
127
to
128
| // FIXME: use Store::topoSortPaths(). | ||
| StorePaths topoSortPaths(const std::map<StorePath, ValidPathInfo> & paths) |
There was a problem hiding this comment.
Hah! I was just about to generalize Store::topoSortPaths myself!
There was a problem hiding this comment.
NixOS/nix#3864 is what I ended up using
grahamc
reviewed
Jul 27, 2020
thefloweringash
added a commit
to thefloweringash/nixos-org-configurations
that referenced
this pull request
Nov 16, 2020
The upstream property memoryTokensInUse was removed by cbcf6359 [1] in NixOS/hydra#795 [2]. [1]: NixOS/hydra@cbcf635 [2]: NixOS/hydra#795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the processing of incoming NARs work in O(1) memory (excluding the NAR content listing). It also makes Hydra build against the current Nix master.
A few other changes:
BuildProductstable. Since we now need to compute hashes over all regular files inside a NAR (because we might not have seenhydra-build-productsyet) it's expensive to have a hash type that's deprecated anyway.TokenServerand thenar_buffer_sizesetting.Fixes #794.