datefudge: work correctly even if GNU date is not in PATH #94045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
Why not go for a patchless approach and use |
|
I agree with @dasJ, please wrap the program. |
KAction
force-pushed
the
fix-datefudge
branch
from
ba29fcb
to
f9bed8f
Compare
|
@SuperSandro2000 @dasJ Applied changes. |
| @@ -1,4 +1,4 @@ | |||
| { stdenv, fetchgit, fetchpatch }: | |||
| { stdenv, lib, fetchgit, fetchpatch, makeWrapper, coreutils ? null }: | |||
There was a problem hiding this comment.
I would prefer if we just always pass in coreutils if this is possible. It would make this file less complex and coreutils is likely already downloaded anyway.
There was a problem hiding this comment.
On build system -- yes, coreutils is part of stdenv. On host system -- not necessary.
|
Result of 1 package built:
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Examples in manual assumes advanced features from date(1) like "last Friday", which only available in GNU coreutils version of date(1) utility. Without this patch, most examples from datefudge(1) manual will fail in busybox environment, which is confusing.
KAction
force-pushed
the
fix-datefudge
branch
from
f9bed8f
to
4036434
Compare
stale
bot
removed
the
2.status: stale
|
Any chance to merge it as I wrote it? I still maintain that avoiding unnecessary dependency worth two conditional statements. @SuperSandro2000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples in manual assumes advanced features from date(1) like "last
Friday", which only available in GNU coreutils version of date(1)
utility. Without this patch, most examples from datefudge(1) manual will
fail in busybox environment, which is confusing.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)