Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qdirstat: 1.6.1 -> 1.7 #94031

Merged
merged 2 commits into from Sep 1, 2020
Merged

qdirstat: 1.6.1 -> 1.7 #94031

merged 2 commits into from Sep 1, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jul 27, 2020

Motivation for this change

https://github.com/shundhammer/qdirstat/releases/tag/1.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@ofborg ofborg bot requested a review from a user July 29, 2020 16:53
@ghost ghost mentioned this pull request Aug 6, 2020
10 tasks
@Atemu
Copy link
Member Author

Atemu commented Aug 22, 2020

/marvin opt-in
/status needs_merger

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 22, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 22, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@Atemu
Copy link
Member Author

Atemu commented Aug 22, 2020

/status needs_reviewer

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
works

Screenshot from 2020-09-01 12-18-20

@davidak
Copy link
Member

davidak commented Sep 1, 2020

/status needs_merger

@timokau
Copy link
Member

timokau commented Sep 1, 2020

Thanks @Atemu for the update and @davidak for the review :)

@timokau timokau merged commit 4b5a5b5 into NixOS:master Sep 1, 2020
@Atemu Atemu deleted the qdirstat-update branch September 1, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants