Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.cpu: unstable-2020-04-05 -> unstable-2020-07-25 #94089

Merged
merged 1 commit into from Sep 8, 2020
Merged

tmuxPlugins.cpu: unstable-2020-04-05 -> unstable-2020-07-25 #94089

merged 1 commit into from Sep 8, 2020

Conversation

cixel
Copy link
Contributor

@cixel cixel commented Jul 28, 2020 •
edited

bump revision for tmux-cpu (885805 -> 20120a).

new revision includes a number of small fixes. motivation for the change
is 5feb11, which fixes an issue calculating ram percentage with vm_stat
(mostly affects macOS).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mweinelt
mweinelt reviewed Jul 28, 2020
View reviewed changes
pkgs/misc/tmux-plugins/default.nix
version = "unstable-2020-04-05";
version = "unstable-2020-07-25";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use these versions in the commit message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@cixel
tmuxPlugins.cpu: unstable-2020-04-05 -> unstable-2020-07-25
387333c 
bump revision for tmux-cpu (885805 -> 20120a).

new revision includes a number of small fixes. motivation for the change
is 5feb11, which fixes an issue calculating ram percentage with vm_stat
(mostly affects macOS).
@cixel cixel changed the title tmuxPlugins.cpu: 885805 -> 20120a tmuxPlugins.cpu: unstable-2020-04-05 -> unstable-2020-07-25 Jul 28, 2020
@cixel cixel requested a review from mweinelt July 28, 2020 17:40
@Lassulus Lassulus merged commit 326ab94 into NixOS:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cixel @mweinelt @Lassulus @Janik-Haag