Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm*: remove symlinks to llvm-diff, llvm-as and LLVM IR utilities #94088

Merged
merged 1 commit into from Jul 28, 2020
Merged

llvm*: remove symlinks to llvm-diff, llvm-as and LLVM IR utilities #94088

merged 1 commit into from Jul 28, 2020

Conversation

DavidTruby
Copy link
Contributor

@DavidTruby DavidTruby commented Jul 28, 2020 •
edited

Motivation for this change

These llvm-prefixed utilities are not drop-in replacements for the utilities
with similar names, they are specifically for operating on LLVM IR files.
Symlinking these without the prefix causes incompatibilities with tools that
expect diff, as and others to behave normally.

Fixes #93523

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DavidTruby
llvm*: remove symlinks to llvm-diff, llvm-as and associated LLVM IR u…
46e5ea5 
…tilities.

These llvm-prefixed utilities are not drop-in replacements for the utilities
with similar names, they are specifically for operating on LLVM IR files.
Symlinking these without the prefix causes incompatibilities with tools that
expect diff, as and others to behave normally.
@Mic92 Mic92 requested a review from dtzWill July 28, 2020 15:51
@matthewbauer matthewbauer merged commit a5659d3 into NixOS:master Jul 28, 2020
matthewbauer added a commit that referenced this pull request Jul 28, 2020
@matthewbauer
llvm: setup some symlinks for compatibility with binutils
b331c72 
This is needed for cross-compiling for LLVM.

After #94088, we still need some
of these, so I’ve whitelisted those that are in binutils.

/cc @DavidTruby
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@matthewbauer @rvem
llvm: setup some symlinks for compatibility with binutils
e22c235 
This is needed for cross-compiling for LLVM.

After NixOS#94088, we still need some
of these, so I’ve whitelisted those that are in binutils.

/cc @DavidTruby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llvm-binutils links llvm-diff to diff
3 participants
@DavidTruby @matthewbauer @Janik-Haag