Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.27.0 -> 2.28.0 #94026

Closed
wants to merge 1 commit into from
Closed

git: 2.27.0 -> 2.28.0 #94026

wants to merge 1 commit into from

Conversation

leo60228
Copy link
Member

Motivation for this change

Git 2.28 adds several new features. Announcement: https://lkml.kernel.org/lkml/xmqq5za8hpir.fsf@gitster.c.googlers.com/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, peti, primeos and wmertens July 27, 2020 19:53
@primeos
Copy link
Member

primeos commented Jul 27, 2020

@GrahamcOfBorg build gitFull

primeos
primeos reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go into staging other than that probably fine (I can test it tomorrow).

primeos pushed a commit that referenced this pull request Jul 28, 2020
@leo60228 @primeos
git: 2.27.0 -> 2.28.0 (#94026)
d42bcde
@primeos
Copy link
Member

primeos commented Jul 28, 2020

Pushed as d42bcde.

@primeos primeos closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos left review comments

@globin globin Awaiting requested review from globin

@peti peti Awaiting requested review from peti

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo60228 @primeos