Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_zen: init at 5.7.10 #94027

Merged
merged 1 commit into from Aug 16, 2020
Merged

linux_zen: init at 5.7.10 #94027

merged 1 commit into from Aug 16, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jul 27, 2020

Motivation for this change

Fixes #74834

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu mentioned this pull request Jul 27, 2020
@Atemu
Copy link
Member Author

Atemu commented Jul 27, 2020

Binary cache to save yourself a kernel build: https://app.cachix.org/cache/atemu

@Oro
Copy link
Contributor

Oro commented Jul 29, 2020

FWIW (I assume anecdotal feedback is helpful for a potential reviewer which is why I am commenting here and not on the Issue): I have been using this patch the last day on nixos-unstable (20.09pre235279.5717d9d2f7c (Nightingale)) and haven't encountered any issues so far.

Built it on NixOS with nvidia's unfree drivers, did not use the cache.

I am using following snippet for /etc/nixos/configuration.nix:

let
  nixpkgs-tars = "https://github.com/NixOS/nixpkgs/archive/";
  pr94027 = import (fetchTarball
    "${nixpkgs-tars}83451174b826146cedbc31d98f16c870a0dd0c45.tar.gz")
    { config = config.nixpkgs.config; };
in {
  boot.kernelPackages = pr94027.linuxPackages_zen;
}

@revelere
Copy link

Successfully built with the above snippet on NixOS with Intel's drivers (20.09pre236091.28fce082c8c (Nightingale)), without the cache too. No problems so far.

@Atemu
Copy link
Member Author

Atemu commented Jul 30, 2020

I just had i3 and journald crash on me and executing anything but dmesg resulted in a segfault afterwards. Looking at the dmesg suggested that that might've been due to nGreedia's proprietary crap but it could also be an incompatibility introduced by Nixpkgs.

I've been using this kernel ever since the PR was opened, so I'd like to have at least one more Nvidia (and preferably also ZFS) user test this for a few days before we merge.

Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me code-style, feel free to mention me when time to merge (I might not react immediately, but will probably merge in a few days)

@bbigras
Copy link
Contributor

bbigras commented Aug 3, 2020

I'm testing 5.7.10-zen1 since yesterday. So far no problems.

@samuelgrf
Copy link
Member

I've tested the kernel on both Amd and Intel hardware and everything works perfectly for me.
I didn't really expect it, but most of my programs feel more responsive, especially Firefox feels noticeably snappier with this kernel.

Specific things tested:
ZFS, zram, web browsing, video playback and the rtl8821CE module; updated via overlay from: #94157

@ndarwincorn
Copy link
Contributor

@samuelgrf - cool to see this working w/ that wifi driver--when I first switched to NixOS I gave up on trying to use the zen kernel when I couldn't get the two to play nice.

@7c6f434c
Copy link
Member

Doesn't looks like there are any changes to be made, and it doesn't looks like there are some obvious issues, so I guess it is good enough…

@7c6f434c 7c6f434c merged commit 657f612 into NixOS:master Aug 16, 2020
@Atemu
Copy link
Member Author

Atemu commented Aug 17, 2020

Thanks for the heads up, I didn't actually consider this. I assumed the patches would activate themselves by default and didn't verify. Looks like that is the case though.

The RQ related config flags aren't set but those don't seem to be used anywhere in the source.

@Atemu
Copy link
Member Author

Atemu commented Aug 17, 2020

Oh, they deleted their comment :S

@Atemu Atemu deleted the zen-kernel-init branch October 7, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of Zen-kernel
7 participants