Initial support for GPD Pocket #48

lbonn · 2018-01-14T14:21:48Z

Here is a small number of settings for a reasonably functional system running on a GPD Pocket

Some parts might be out of scope for this repo (the environment variables at the end?). I'll let you be the judge of that: please tell me what I should remove.

andir · 2018-01-14T15:00:46Z

Another GPD Pocket User 👍

Have a look at https://github.com/andir/nixos-gpd-pocket those are my configuration files for the gpd pocket. I am currently running nixos unstable on it since there are a few parts that have been patched in newer alsa, kernel, … versions. It also comes with the (almost always) latest version of the Kernel of Hans de Goede (RedHat employee that works on the hardware support for this and many other devices).

Things that do work for me with those settings:

booting it with a image created from the repo
X Server rotation (gnome does it's own thing os that is still broken, Has has submitted patches to gnome and they are in gnome master, will be released with next stable release IIRC)
WiFi works - I bundled that custom pci textfile that was required
Suspend/Resume works
Charging Support (via USB-C PD)
Backlight controls are working
…

I did intend to provide those changes to this repo as soon as everything is mainline/upstream. Feel free to pull those changes into your PR :-)

lbonn · 2018-01-14T15:13:03Z

Thanks, that looks indeed more polished, I'll look into it.

This setup is also intended to be used on the unstable channel, with a stock 4.14 kernel. As a result some of the support is still missing. On the plus side, this could already be mergeable and updated later (on 4.15's release?)

But I also realized that I forgot to include the brcmfmac4356 firmware anyway so my PR won't work as is.

Definitely opened it too fast...

andir · 2018-01-14T15:23:02Z

Yep, mailine support is what this repo should probably prefer.

Don't worry. That is why there is review :-) You can improve over time.

lukateras · 2018-01-14T17:09:04Z

gpd/gpd-pocket/default.nix

+  };
+
+  # wifi
+  nixpkgs.config.allowUnfree = true;


It should be up to the end user whether to allow unfree packages or not, even when crucial to hardware functionality.

Moreover, it would make sense to only enable the firmware if user explicitly allows unfree packages, so that people that don't install unfree packages can still use the profile, even if without functioning Wi-Fi:

nixpkgs.firmware = with pkgs; lib.optionals config.nixpkgs.config.allowUnfree [ brcmfmac4356-firmware ]

See:

nixos-hardware/apple/default.nix

Lines 8 to 9 in 88bd126

hardware.facetimehd.enable = lib.mkDefault

(config.nixpkgs.config.allowUnfree or false);

lukateras · 2018-01-14T17:09:30Z

gpd/gpd-pocket/default.nix

+  # wifi
+  nixpkgs.config.allowUnfree = true;
+  hardware.firmware = with pkgs; [
+    brcmfmac4356-firmware


This doesn't evaluate:

undefined variable brcmfmac4356-firmware at /home/travis/build/NixOS/nixos-hardware/gpd/gpd-pocket/default.nix:29:5

lukateras · 2018-01-14T17:12:47Z

gpd/gpd-pocket/default.nix

+
+  # power management
+  services.tlp = {
+    enable = true;


This is already defined in laptop profile:

nixos-hardware/common/pc/laptop/default.nix

Line 12 in 5a00ea4

services.tlp.enable = lib.mkDefault true;

lukateras · 2018-01-14T17:14:43Z

gpd/gpd-pocket/default.nix

+    '';
+    xrandrHeads = [ { output= "DSI1"; monitorConfig = "Option \"Rotate\" \"right\""; } ];
+    libinput = {
+      enable = true;


This is already defined in PC profile:

nixos-hardware/common/pc/default.nix

Line 4 in 5a00ea4

services.xserver.libinput.enable = lib.mkDefault true;

lukateras

Also, gpd/gpd-pocket should be moved to gpd/pocket, following the current naming convention.

lukateras · 2018-01-14T17:18:54Z

gpd/gpd-pocket/default.nix

+  };
+
+  environment.variables = {
+    GDK_SCALE = "2";         # DPI


All non-mergable attributes should be set via lib.mkDefault so that they can be overrided in user profile:

GDK_SCALE = lib.mkDefault "2";

lukateras · 2018-01-14T17:21:44Z

gpd/gpd-pocket/default.nix

+    libinput = {
+      enable = true;
+    };
+    inputClassSections = [''


Is this required to discover input devices?

lukateras · 2018-01-14T17:22:52Z

gpd/gpd-pocket/default.nix

+      Option      "TearFree"        "true"
+      Option      "DRI"             "3"
+    '';
+    xrandrHeads = [ { output= "DSI1"; monitorConfig = "Option \"Rotate\" \"right\""; } ];


Nitpick: "Option \"Rotate\" \"right\"" -> ''Option "Rotate" "right"''
Also, it would be easier to read with each attribute on a separate line.

lukateras · 2018-01-14T17:23:30Z

gpd/gpd-pocket/default.nix

+  services.xserver = {
+    dpi = 168;
+    deviceSection = ''
+      Option      "AccelMethod"     "sna"


Does explicit acceleration method affect anything?

lukateras · 2018-01-14T17:24:35Z

gpd/gpd-pocket/default.nix

+  };
+
+  # TODO: fix media keys
+  # sound.mediaKeys.enable = true;


sound.mediaKeys.enable overlaps with some desktop managers (e.g. Xfce), which is why it is not set in this repo even if the device does have media keys.

lukateras · 2018-01-14T17:25:58Z

gpd/gpd-pocket/default.nix

+  hardware.pulseaudio = {
+    enable = true;
+    extraConfig = ''
+      set-card-profile alsa_card.platform-cht-bsw-rt5645 HiFi


Is this required to make audio work?

There are some hacks required with current mainline kernels. This will change in the future (4.15+).
I am not sure if this is exactly the one since I've been running the 4.15-rc kernels on mine.

lukateras · 2018-01-14T17:27:26Z

gpd/gpd-pocket/default.nix

+      set-sink-port alsa_output.platform-cht-bsw-rt5645.HiFi__hw_chtrt5645_0__sink [Out] Speaker
+    '';
+    daemon.config = {
+      realtime-scheduling = "no";


Why is it disabled?

lukateras · 2018-01-14T17:29:49Z

gpd/gpd-pocket/default.nix

+  };
+
+  hardware.pulseaudio = {
+    enable = true;


So far there are no profiles that explicitly depend on PulseAudio: the idea is to not force PulseAudio (there are cases that warrant pure ALSA setup, or Jack). Extra configuration for PulseAudio (to make it work once it's enabled) is of course welcome.

lukateras · 2018-01-14T18:07:53Z

Also, would you license this work under CC0-1.0? License is not in the master branch yet, see #47.

lbonn · 2018-01-15T23:38:21Z

Licensing it under CC0-1.0 is fine by me, if @andir also agrees for the part I'd eventually take from their repo.

I tried to apply some of your changes and I'll do some test later to verify that nothing is extraneous.

About the wifi firmware, I suppose it's not really the place to put some blobs (see https://github.com/andir/nixos-gpd-pocket/tree/master/firmware). Would there be an alternate solution, for example leaving some instructions for the user to add and include from another channel?

andir · 2018-01-15T23:40:34Z

For what it is worth you could pull that from my repo.... I also grant permission to re-use my configuration from THAT repo under CC0-1.0.

lukateras · 2018-01-16T03:49:31Z

I think blob here will do, but it could be merged with Nixpkgs for a wider reach, perhaps later.

Mic92 · 2018-03-09T07:39:43Z

any news here?

lbonn · 2018-03-12T08:09:35Z

@Mic92 I'm a bit short on time these days unfortunately, if someone wants to make progress on that, be my guest

Ma27 · 2018-03-12T10:37:17Z

@lbonn wrong username? ;)

lbonn · 2018-03-12T10:53:57Z

Oops, sorry

grahamc · 2018-03-12T11:11:56Z

Please don't put blobs in this repo, though

…

On Mar 12, 2018 6:53 AM, "lbonn" ***@***.***> wrote: Oops, sorry — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#48 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAErrHCccuDrkyBffA2haerm1h3f0pOlks5tdlPGgaJpZM4Rdm96> .

matthew-piziak · 2018-11-09T01:04:09Z

The GPD Pocket 2 is out now. Anybody running NixOS on that machine yet?

yrashk · 2019-04-24T08:55:19Z

@matthew-piziak I should be getting my Pocket 2 soon, interested to try out!

matthew-piziak · 2019-04-24T12:33:08Z

@yrashk Exciting! Looking forward to hearing what you think. For what it's worth, I'm now using this configuration on a GDP 1 of my own. Works great!

Mic92 · 2020-07-28T08:48:18Z

Looks like this PR got stalled. If someone wants to open a new PR, feel free.

lukateras reviewed Jan 14, 2018

View reviewed changes

lukateras requested changes Jan 14, 2018

View reviewed changes

gpd: initial support for GPD Pocket

055d98a

lbonn force-pushed the gpd-pocket-initial branch from 66bae91 to 055d98a Compare January 15, 2018 23:29

lukateras mentioned this pull request Feb 2, 2018

LICENSE: license under CC0-1.0 #47

Merged

19 tasks

andir mentioned this pull request Mar 2, 2018

Please remove the root ssh backdoor andir/nixos-gpd-pocket#1

Open

Mic92 closed this Jul 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial support for GPD Pocket #48

Initial support for GPD Pocket #48

lbonn commented Jan 14, 2018

andir commented Jan 14, 2018

lbonn commented Jan 14, 2018

andir commented Jan 14, 2018

lukateras Jan 14, 2018 •

edited

lukateras Jan 14, 2018

lukateras Jan 14, 2018

lukateras Jan 14, 2018

lukateras left a comment

lukateras Jan 14, 2018

lukateras Jan 14, 2018

lukateras Jan 14, 2018 •

edited

lukateras Jan 14, 2018

lukateras Jan 14, 2018

lukateras Jan 14, 2018

andir Jan 14, 2018

lukateras Jan 14, 2018

lukateras Jan 14, 2018 •

edited

lukateras commented Jan 14, 2018 •

edited

lbonn commented Jan 15, 2018

andir commented Jan 15, 2018

lukateras commented Jan 16, 2018

Mic92 commented Mar 9, 2018

lbonn commented Mar 12, 2018 •

edited

Ma27 commented Mar 12, 2018

lbonn commented Mar 12, 2018

grahamc commented Mar 12, 2018 via email

matthew-piziak commented Nov 9, 2018

yrashk commented Apr 24, 2019

matthew-piziak commented Apr 24, 2019

Mic92 commented Jul 28, 2020

	hardware.facetimehd.enable = lib.mkDefault
	(config.nixpkgs.config.allowUnfree or false);

Initial support for GPD Pocket #48

Initial support for GPD Pocket #48

Conversation

lbonn commented Jan 14, 2018

andir commented Jan 14, 2018

lbonn commented Jan 14, 2018

andir commented Jan 14, 2018

lukateras Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras Jan 14, 2018 • edited

Choose a reason for hiding this comment

lukateras commented Jan 14, 2018 • edited

lbonn commented Jan 15, 2018

andir commented Jan 15, 2018

lukateras commented Jan 16, 2018

Mic92 commented Mar 9, 2018

lbonn commented Mar 12, 2018 • edited

Ma27 commented Mar 12, 2018

lbonn commented Mar 12, 2018

grahamc commented Mar 12, 2018 via email

matthew-piziak commented Nov 9, 2018

yrashk commented Apr 24, 2019

matthew-piziak commented Apr 24, 2019

Mic92 commented Jul 28, 2020

lukateras Jan 14, 2018 •

edited

lukateras Jan 14, 2018 •

edited

lukateras Jan 14, 2018 •

edited

lukateras commented Jan 14, 2018 •

edited

lbonn commented Mar 12, 2018 •

edited