Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlp: use structured config to fix cpu governor #94064

Merged
merged 1 commit into from Aug 1, 2020
Merged

tlp: use structured config to fix cpu governor #94064

merged 1 commit into from Aug 1, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 28, 2020 •
edited

Previously this module just disabled them.
Now tlp merges system defaults in

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
tlp: use structured config to fix cpu governor
4d0077a 
Previously this module just disabled them.
Now tlp merges system defaults in
@Mic92 Mic92 mentioned this pull request Jul 28, 2020
Merged
bahaynes added a commit to bahaynes/nixos-hardware that referenced this pull request Jul 30, 2020
@bahaynes
Removed tlp configuration.
cc72f59 
Should be set correctly after NixOS/nixpkgs#94064
is merged.
@Mic92 Mic92 merged commit 6339587 into NixOS:master Aug 1, 2020
@Mic92 Mic92 deleted the tlp branch August 1, 2020 09:23
mebubo added a commit to mebubo/dotfiles that referenced this pull request Sep 15, 2020
@mebubo
nixos: don't set cpuFreqGovernor; let tlp handle it
6183896 
powerManagement.cpuFreqGovernor used to be ignored if tlp was also
enabled, but since NixOS/nixpkgs#94064 this setting is now propagated
into the tlp config (for both BAT and AC, which was causing low
performance with cpuFreqGovernor='powersave')
@andersk andersk mentioned this pull request Apr 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92