Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJDK: Update 11 and 14 per July 2020 CPU #94029

Closed
wants to merge 1 commit into from
Closed

OpenJDK: Update 11 and 14 per July 2020 CPU #94029

wants to merge 1 commit into from

Conversation

jerith666
Copy link
Contributor

Motivation for this change

Among other things, this fixes a build failure in 14 caused by updating to gnumake 4.3 (0cfe9f3):

Building target 'all' in configuration 'linux-x86_64-server-release'
make[3]: *** No rule to make target '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/buildtools/langtools_tools_classes/_the.BUILD_TOOLS_LANGTOOLS.vardeps', needed by '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/buildtools/langtools_tools_classes/_the.BUILD_TOOLS_LANGTOOLS_batch'.  Stop.
make[3]: *** Waiting for unfinished jobs....
Warning: No SCM configuration present and no .src-rev
make[2]: *** [make/Main.gmk:70: buildtools-langtools] Error 2
make[2]: *** Waiting for unfinished jobs....
make[3]: *** No rule to make target '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/make-support/vardeps/make/ModuleWrapper.gmk/java.base/ORDERED_CFG_VARIANTS.vardeps', needed by '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/support/modules_libs/java.base/jvm.cfg'.  Stop.
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [make/Main.gmk:158: java.base-copy] Error 2
make[3]: *** No rule to make target '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/make-support/vardeps/make/ReleaseFile.gmk/create-info-file.vardeps', needed by '/build/jdk14u-jdk-14.0.1-ga/build/linux-x86_64-server-release/jdk/release'.  Stop.
make[2]: *** [make/Main.gmk:405: release-file] Error 2

ERROR: Build failed for target 'all' in configuration 'linux-x86_64-server-release' (exit code 2)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo July 27, 2020 21:12
@jerith666
Copy link
Contributor Author

partial overlap with #94528 here; cc @asbachb

@jerith666
Copy link
Contributor Author

in particular we arrived at different checksums since I used the -ga release while #94528 used the +10 release. But I pulled down both tarballs, and the contents are identical, they just contain different top-level directories.

So, I'll rebase this to include only the update to 14.

@jerith666
Copy link
Contributor Author

whoops, and the 14 update is already done in #94548! (cc @bachp) great to see so many folks helping keep the nixpkgs jdks up-to-date! :)

@jerith666 jerith666 closed this Aug 7, 2020
This was referenced Aug 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jerith666