Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.webdavclient3: init at 3.14.5 #94070

Merged
merged 1 commit into from Jul 28, 2020
Merged

pythonPackages.webdavclient3: init at 3.14.5 #94070

merged 1 commit into from Jul 28, 2020

Conversation

dmrauh
Copy link
Contributor

@dmrauh dmrauh commented Jul 28, 2020

Motivation for this change

I needed a Python-based WebDAV client library, that can be imported as a module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) 0 -> 127593712
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mweinelt
mweinelt requested changes Jul 28, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you don't run tests it is customary to at least add import checks.

pkgs/development/python-modules/webdavclient3/default.nix Show resolved Hide resolved
pkgs/development/python-modules/webdavclient3/default.nix Outdated Show resolved Hide resolved
@dmrauh dmrauh requested a review from mweinelt July 28, 2020 13:40
@mweinelt mweinelt merged commit 83f41b7 into NixOS:master Jul 28, 2020
mweinelt
mweinelt approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmrauh
Copy link
Contributor Author

dmrauh commented Jul 28, 2020

Thank you 😀

@dmrauh dmrauh deleted the add/webdavclient3 branch July 28, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmrauh @mweinelt