Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.06.16.1 -> 2020.07.28 #94036

Merged
merged 1 commit into from Jul 27, 2020
Merged

youtube-dl: 2020.06.16.1 -> 2020.07.28 #94036

merged 1 commit into from Jul 27, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 27, 2020

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.07.28

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq mentioned this pull request Jul 27, 2020
Closed
10 tasks
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 27, 2020
@Ma27 Ma27 merged commit ca7f4a5 into NixOS:master Jul 27, 2020
@Ma27
Copy link
Member

Ma27 commented Jul 27, 2020

Thanks! Backported as eeb91b0 to stable.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2020
@zowoq zowoq deleted the ytdl branch July 27, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

@Ma27 Ma27 Awaiting requested review from Ma27

@Enzime Enzime Awaiting requested review from Enzime

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Ma27