Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.urwid: 2.1.0 -> 2.1.1 #94034

Merged
merged 1 commit into from Jul 28, 2020
Merged

pythonPackages.urwid: 2.1.0 -> 2.1.1 #94034

merged 1 commit into from Jul 28, 2020

Conversation

veehaitch
Copy link
Member

Motivation for this change

New version; also latest Mitmproxy depends on it.

Tests run fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 5a845cd into NixOS:master Jul 28, 2020
@kidd
Copy link
Member

kidd commented Aug 3, 2020 •
edited

I'm not sure how to tackle this, but I recently updated my channels (unstable) and getting this issue with urwid (python2.7). Here's the logs just in case it's helpful to anyone:

nixos-rebuild switch -v
https://gist.github.com/kidd/fe75e247756e2ad18bcc3793633a6c22

trying to build just that package fails in the same way:

 ~/programmingStuff/nixpkgs $ nix repl                                                                                                                                                       
 Welcome to Nix version 2.3.7. Type :? for help.                                                                                                                                                                     
 nix-repl> :l ./                                                                                                                                                                                                     
 Added 12175 variables.
 nix-repl> :b python27Packages.urwid     
builder for '/nix/store/4c764s06m509s5a0m91j8gvywp5ipk7i-python2.7-urwid-2.1.1.drv' failed with exit code 1; last 10 log lines:
      self.module)
    File "/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
      suites = [self.loadTestsFromName(name, module) for name in names]
    File "/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/lib/python2.7/unittest/loader.py", line 103, in loadTestsFromName
      return self.loadTestsFromModule(obj)
    File "/nix/store/hcdzwm3d90p9qa4082il8ja6n6x1q03b-python2.7-setuptools-44.0.0/lib/python2.7/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
      tests.append(self.loadTestsFromName(submodule))
    File "/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/lib/python2.7/unittest/loader.py", line 100, in loadTestsFromName
      parent, obj = obj, getattr(obj, part)
  AttributeError: 'module' object has no attribute 'test_container'
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/4c764s06m509s5a0m91j8gvywp5ipk7i-python2.7-urwid-2.1.1.drv' failed

@kidd kidd mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veehaitch @kidd @FRidh