Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as-tree: init at 0.12.0 #94074

Merged
merged 2 commits into from Nov 7, 2020
Merged

as-tree: init at 0.12.0 #94074

merged 2 commits into from Nov 7, 2020

Conversation

jshholland
Copy link
Contributor

Motivation for this change

Add new package as-tree.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jshholland jshholland changed the title As tree Add as-tree Jul 28, 2020
syberant
syberant reviewed Aug 1, 2020
View reviewed changes
Copy link
Member

@syberant syberant left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also tested building and running the binary on NixOS and haven't encountered any errors.

pkgs/tools/misc/as-tree/default.nix Show resolved Hide resolved
@jshholland
Copy link
Contributor Author

Rebased and added changes suggested by @syberant, thanks for the review and apologies it's taken so long to fix it up!

syberant
syberant approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@syberant syberant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine when testing with nixpkgs-review pr 94074.

@eyJhb
Copy link
Member

eyJhb commented Nov 7, 2020

Works fine for me as well :)

@stigtsp stigtsp changed the title Add as-tree as-tree: 0.11.1 -> 0.12.0 Nov 7, 2020
stigtsp
stigtsp approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Built and tested OK on linux x64

Result of nixpkgs-review pr 94074 1

1 package built:
  • as-tree

@stigtsp stigtsp changed the title as-tree: 0.11.1 -> 0.12.0 as-tree: init at 0.12.0 Nov 7, 2020
@stigtsp stigtsp merged commit 04b374e into NixOS:master Nov 7, 2020
@jshholland
Copy link
Contributor Author

Thanks! My first package into nixpkgs :)

@jshholland jshholland deleted the as-tree branch November 7, 2020 13:08
@stigtsp
Copy link
Member

stigtsp commented Nov 7, 2020

Thanks! My first package into nixpkgs :)

Thank you for the contribution, and welcome to the NixOS project 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@syberant syberant syberant approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jshholland @eyJhb @stigtsp @syberant