Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sentry-sdk: fix trytond dependency #94082

Merged
merged 1 commit into from Jul 28, 2020
Merged

pythonPackages.sentry-sdk: fix trytond dependency #94082

merged 1 commit into from Jul 28, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Jul 28, 2020

Motivation for this change

The trytond dependency of sentry-sdk causes a transitive dependency on simplejson, which then makes requests behave differently in a way that can break error handling.

Tryton is an optional dependency of the Sentry SDK, if it is present, Sentry can integrate with it, but when it is not present, Sentry should not pull it in as a propagated build input, it is only required for the tests that test this specific integration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ruuda
python3Packages.sentry-sdk: fix trytond dependency
e143c2e 
Tryton is an optional dependency, if it is present, Sentry can integrate
it, but when it is not present, Sentry should not pull it in as a
propagated build input, it is only required for the tests that test this
specific integration.

In particular, pulling in trytond creates a transitive dependency on
simplejson, which makes "requests" behave differently in a way that can
break error handling.
@ruuda ruuda mentioned this pull request Jul 28, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from gebner July 28, 2020 15:10
jonringer
jonringer approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94082 1

6 packages built: - cura - gns3-gui - gns3-server - octoprint - python37Packages.sentry-sdk - python38Packages.sentry-sdk

@jonringer jonringer merged commit 302aed5 into NixOS:master Jul 28, 2020
@ruuda ruuda deleted the sentry-trytond branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruuda @jonringer