obs: gstreamer plugin #94067
Closed
obs: gstreamer plugin #94067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, since the workaround No. 2 is actually similar with other system/user-wide plugins like LV2, and No. 1 applies to any obs plugin, not just this one, I think I'm going to submit this as is. |
Lassulus
reviewed
Sep 10, 2020
jb55
suggested changes
Sep 10, 2020
jb55
reviewed
Sep 10, 2020
SuperSandro2000
requested changes
Jan 18, 2021
| @@ -8919,6 +8919,16 @@ | |||
| githubId = 687198; | |||
| name = "Yuri Aisaka"; | |||
| }; | |||
| yurkobb = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add yurkobb.
| sha256 = "1szfx5p2lb953blzw7prfd0nngjlwv2wn7jmnwvlssc9ci6jl6s8"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ meson ninja pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ meson ninja pkgconfig ]; | |
| nativeBuildInputs = [ meson ninja pkg-config ]; |
| , fetchFromGitHub | ||
| , gstreamer | ||
| , gst-plugins-base | ||
| , pkgconfig |
There was a problem hiding this comment.
Suggested change
| , pkgconfig | |
| , pkg-config |
| meta = with lib; { | ||
| description = "GStreamer OBS Studio plugin"; | ||
| homepage = "https://github.com/fzwoch/obs-gstreamer"; | ||
| license = licenses.gpl2; |
|
This should benefit nicely from #125308 |
Oh, that's great news and will make using obs with plugins much easier! P.S. Regarding this PR, someone has already packaged obs-gstreamer in the meantime, so I think it can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the obs-gstreamer OBS plugin (useful for things like attaching sources OBS doesn't support natively, but gstreamer does, like firewire (H)DV cameras, among other things).
Need help with
Currently there are two issues with path lookup:
ln -s ~/.nix-profile/lib/obs-plugins/obs-gstreamer.so ~/.config/obs-studio/plugin/obs-gstreamer/bin/64bit/I am not sure if #1 needs patching OBS to support loading plugins from the system and user profiles (at least i can't find any environment variables to tweak by searching for getenv calls in its source code).
About #2 - have no idea how to fix this... Still a nixpkgs newbie...
(cc @jb55 @MP2E from
default.nixmaintainers).Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)