packagekit: update to flakes branch #94055

matthewbauer · 2020-07-28T04:55:38Z

This is most of the way toward
#21230. We will need a new Nix
release and some more extensive testing before merging it into
PackageKit.

Upstream branch: PackageKit/PackageKit#414

Motivation for this change

Things done

nixos-discourse · 2020-07-28T05:00:26Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/try-out-the-updated-nix-backend-in-packagekit-with-flakes-support/8343/1

nixos/modules/services/misc/packagekit.nix

worldofpeace · 2020-07-28T07:10:38Z

I'm noticing something inside packagekit lib/gtk-3.0/modules/libpk-gtk-module.so.
I think in order for this to be used we need to add this into GTK3_MODULES environment variable.

worldofpeace · 2020-07-28T08:29:35Z

I've tried it in a VM.

pkcon get-packages
pkcon install celluloid
celluloid

I was able to start celluloid.

I noticed two things atm:

packages under like gnome3. or pantheon. attributes don't show up in search results (so you can't install them)
removing packages seems broken?
Needs to be looked into deeper, but it seems to show a success to remove a package, but nix-env -q would show it still installed.

Haven't tried gui's like gnome-software yet, though, I'm betting they will be broken.

Will try to get good backtraces when I get to test it more and probably run into some crashes.

worldofpeace · 2020-07-28T08:32:19Z

Unrelated nit in the PR, packagekit.nix vendorConf could have a let url = "https://github.com/NixOS/nixpkgs"; so we don't repeat the same string a bunch of times.

matthewbauer · 2020-07-28T17:25:24Z

packages under like gnome3. or pantheon. attributes don't show up in search results (so you can't install them)

Yeah the recurseForDerivations feature is missing. It's easy to add though since nix search supports it as well.

removing packages seems broken?

I had install / remove working, but there may be an issue if the thing installed is a different path than what's in nixpkgs. I'll take a look.

matthewbauer · 2020-07-29T03:04:52Z

Haven't tried gui's like gnome-software yet, though, I'm betting they will be broken.

I just tried gnome-packagekit, and it works fairly well. There's probably some polishing that could make it a bit better, but it can do basic search & install.

As for GNOME Software, we need indexing of metainfo to get the prettier displays (#15932). I'm not sure if it shows anything without that.

wmertens · 2021-03-09T13:44:28Z

I'm curious what the state of this is, it's not obvious from looking at the various issues. It seems to me that this is a great boon for increasing the NixOS userbase?

matthewbauer · 2021-03-09T20:13:41Z

I'm curious what the state of this is, it's not obvious from looking at the various issues. It seems to me that this is a great boon for increasing the NixOS userbase?

Yep! The main thing holding it back is that Nix with caching support is not officially released. I'm hoping that happens soon and we can start merging this and the packagekit PR.

stale · 2021-09-06T18:24:39Z

I marked this as stale due to inactivity. → More info

lapp0 · 2021-11-21T19:17:43Z

@matthewbauer with nix 2.4 released, should this PR process continue? I'd like to have this feature.

matthewbauer · 2022-02-08T03:21:45Z

@worldofpeace Care to review again? It should be ready to go now that the work is merged upstream.

davidak · 2022-02-08T12:50:10Z

worldofpeace left the project. maybe someone else can review it?

i don't see any obvious issue, but i don't know much about packagekit

can it already be tested? what should work after this PR?

pkgs/tools/package-management/packagekit/default.nix

jtojnar · 2022-02-08T15:18:21Z

pkgs/tools/package-management/packagekit/default.nix

-    "--enable-introspection"
-    "--disable-offline-update"
-    "--localstatedir=/var"
-    "--sysconfdir=/etc"


I am afraid PackageKit will use configs from ${out}/etc without this. We might either patch the runtime paths (example), or hack around this using DESTDIR (example).

should it use configs from /etc? Where should the state be stored?

I can't figure out how it does installs, does it manage the user profile via nix-env?

State should go to localstatedir (which suffers from the same issue as sysconfdir). Though I would expect it to be mostly stateless (maybe there are some caches).

pkgs/tools/package-management/packagekit/default.nix

jtojnar · 2022-02-09T00:04:06Z

Tried it in a GNOME VM

--- a/nixos/modules/services/x11/desktop-managers/gnome.nix
+++ b/nixos/modules/services/x11/desktop-managers/gnome.nix
@@ -532,9 +532,6 @@ in
             simple-scan
             totem
             yelp
-          ] ++ lib.optionals config.services.flatpak.enable [
-            # Since PackageKit Nix support is not there yet,
-            # only install gnome-software if flatpak is enabled.
             gnome-software
           ])
           config.environment.gnome.excludePackages;

and got a crash on startup (probably triggered by GNOME Software):

Feb 08 23:54:14 nixos PackageKit[1643]: uid 1000 is trying to obtain org.freedesktop.packagekit.system-sources-refresh auth (only_trusted:0)
Feb 08 23:54:14 nixos PackageKit[1643]: uid 1000 obtained auth for org.freedesktop.packagekit.system-sources-refresh
Feb 08 23:54:14 nixos packagekitd[1643]: **
Feb 08 23:54:14 nixos packagekitd[1643]: PackageKit-Nix:ERROR:../backends/nix/pk-backend-nix.cc:244:void nix_search_thread(PkBackendJob*, GVariant*, gpointer): code should not be reached
Feb 08 23:54:14 nixos packagekitd[1643]: Bail out! PackageKit-Nix:ERROR:../backends/nix/pk-backend-nix.cc:244:void nix_search_thread(PkBackendJob*, GVariant*, gpointer): code should not be reached
Feb 08 23:54:14 nixos systemd[1]: Started Process Core Dump (PID 1702/UID 0).

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007f0e4394c533 in __GI_abort () at abort.c:79
#2  0x00007f0e43fc7ddc in g_assertion_message (domain=<optimized out>, file=0x7f0e419940f0 "../backends/nix/pk-backend-nix.cc", line=<optimized out>, func=<optimized out>, message=<optimized out>)
    at ../glib/gtestutils.c:3223
#3  0x00007f0e44026f3b in g_assertion_message_expr (domain=domain@entry=0x7f0e41994125 "PackageKit-Nix", file=file@entry=0x7f0e419940f0 "../backends/nix/pk-backend-nix.cc", line=line@entry=244, 
    func=func@entry=0x7f0e419940b0 "void nix_search_thread(PkBackendJob*, GVariant*, gpointer)", expr=expr@entry=0x0) at ../glib/gtestutils.c:3249
#4  0x00007f0e419718df in nix_search_thread (job=<optimized out>, params=0x16930a0, p=<optimized out>) at ../backends/nix/pk-backend-nix.cc:244
#5  0x00007f0e41971a0f in nix_refresh_thread (job=0x168a480, params=<optimized out>, p=<optimized out>) at ../backends/nix/pk-backend-nix.cc:438
#6  0x000000000042350a in pk_backend_job_thread_setup (thread_data=0x15748c0) at ../src/pk-backend-job.c:724
#7  0x00007f0e44027e0d in g_thread_proxy (data=0x157e460) at ../glib/gthread.c:827
#8  0x00007f0e43b04d40 in start_thread (arg=0x7f0e1aec2640) at pthread_create.c:481
#9  0x00007f0e43a2203f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

We might want to add separateDebugInfo = true; to make debugging easier.

matthewbauer · 2022-02-09T00:45:24Z

Tried it in a GNOME VM

--- a/nixos/modules/services/x11/desktop-managers/gnome.nix
+++ b/nixos/modules/services/x11/desktop-managers/gnome.nix
@@ -532,9 +532,6 @@ in
             simple-scan
             totem
             yelp
-          ] ++ lib.optionals config.services.flatpak.enable [
-            # Since PackageKit Nix support is not there yet,
-            # only install gnome-software if flatpak is enabled.
             gnome-software
           ])
           config.environment.gnome.excludePackages;

and got a crash on startup (probably triggered by GNOME Software):

Feb 08 23:54:14 nixos PackageKit[1643]: uid 1000 is trying to obtain org.freedesktop.packagekit.system-sources-refresh auth (only_trusted:0)
Feb 08 23:54:14 nixos PackageKit[1643]: uid 1000 obtained auth for org.freedesktop.packagekit.system-sources-refresh
Feb 08 23:54:14 nixos packagekitd[1643]: **
Feb 08 23:54:14 nixos packagekitd[1643]: PackageKit-Nix:ERROR:../backends/nix/pk-backend-nix.cc:244:void nix_search_thread(PkBackendJob*, GVariant*, gpointer): code should not be reached
Feb 08 23:54:14 nixos packagekitd[1643]: Bail out! PackageKit-Nix:ERROR:../backends/nix/pk-backend-nix.cc:244:void nix_search_thread(PkBackendJob*, GVariant*, gpointer): code should not be reached
Feb 08 23:54:14 nixos systemd[1]: Started Process Core Dump (PID 1702/UID 0).

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007f0e4394c533 in __GI_abort () at abort.c:79
#2  0x00007f0e43fc7ddc in g_assertion_message (domain=<optimized out>, file=0x7f0e419940f0 "../backends/nix/pk-backend-nix.cc", line=<optimized out>, func=<optimized out>, message=<optimized out>)
   at ../glib/gtestutils.c:3223
#3  0x00007f0e44026f3b in g_assertion_message_expr (domain=domain@entry=0x7f0e41994125 "PackageKit-Nix", file=file@entry=0x7f0e419940f0 "../backends/nix/pk-backend-nix.cc", line=line@entry=244, 
   func=func@entry=0x7f0e419940b0 "void nix_search_thread(PkBackendJob*, GVariant*, gpointer)", expr=expr@entry=0x0) at ../glib/gtestutils.c:3249
#4  0x00007f0e419718df in nix_search_thread (job=<optimized out>, params=0x16930a0, p=<optimized out>) at ../backends/nix/pk-backend-nix.cc:244
#5  0x00007f0e41971a0f in nix_refresh_thread (job=0x168a480, params=<optimized out>, p=<optimized out>) at ../backends/nix/pk-backend-nix.cc:438
#6  0x000000000042350a in pk_backend_job_thread_setup (thread_data=0x15748c0) at ../src/pk-backend-job.c:724
#7  0x00007f0e44027e0d in g_thread_proxy (data=0x157e460) at ../glib/gthread.c:827
#8  0x00007f0e43b04d40 in start_thread (arg=0x7f0e1aec2640) at pthread_create.c:481
#9  0x00007f0e43a2203f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

We might want to add separateDebugInfo = true; to make debugging easier.

That was a bug in my packagekit code - there's an assert that we don't want : https://github.com/PackageKit/PackageKit/blob/main/backends/nix/pk-backend-nix.cc#L244

Should be fixed !

jtojnar · 2022-02-09T00:59:48Z

Can confirm org.freedesktop.packagekit.system-sources-refresh triggered by the refresh in GNOME Software works. GNOME Software is still empty – I guess that depends on #15932.

Can confirm the following works:

pkcon get-packages
pkcon install celluloid

Had to increase the VM memory limit (get-packages froze on 2G).

Can you please rebase/squash?

Fixes NixOS#21230 Use Nix backend for packagekit. Updates to version with my Nix backend for PackageKit.

jtojnar

LGTM, thanks.

thufschmitt · 2022-02-28T16:26:12Z

This is causing some troubles because it’s relying on the unstable Nix C++ api and is broken with the latest unstable Nix − meaning that it’s not possible to build a system with gnome and the latest Nix anymore.

Is there any strong reason for making the Nix support mandatory and on-by-default?

jtojnar · 2022-02-28T17:30:33Z

@thufschmitt PackageKit is pretty much useless for us without Nix support. And Nix does not really allow us to enable optional features deep in dependency closure easily.

matthewbauer mentioned this pull request Jul 28, 2020

Packagekit not compiling with Nix-backend enabled #21230

Closed

ofborg bot added 6.topic: nixos 8.has: module (update) labels Jul 28, 2020

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 28, 2020

worldofpeace reviewed Jul 28, 2020

View reviewed changes

nixos/modules/services/misc/packagekit.nix Outdated Show resolved Hide resolved

worldofpeace mentioned this pull request Jul 29, 2020

RFC: Generating AppStream Metadata #15932

Open

ryantm marked this pull request as draft October 23, 2020 02:59

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

davidak mentioned this pull request Sep 1, 2021

Package Manager nix-gui/nix-gui#85

Open

5 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 21, 2021

aviallon mentioned this pull request Dec 17, 2021

Nix backend for PackageKit / Gnome-Software NixOS/nix#233

Closed

matthewbauer changed the title ~~[wip] packagekit: update to flakes branch~~ packagekit: update to flakes branch Feb 8, 2022

matthewbauer marked this pull request as ready for review February 8, 2022 03:21

ofborg bot removed the 2.status: merge conflict label Feb 8, 2022

jtojnar reviewed Feb 8, 2022

View reviewed changes

pkgs/tools/package-management/packagekit/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Feb 8, 2022

View reviewed changes

matthewbauer requested review from jtojnar and wmertens February 8, 2022 17:32

jtojnar reviewed Feb 8, 2022

View reviewed changes

pkgs/tools/package-management/packagekit/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Feb 8, 2022

View reviewed changes

pkgs/tools/package-management/packagekit/default.nix Outdated Show resolved Hide resolved

matthewbauer requested a review from jtojnar February 8, 2022 23:28

matthewbauer force-pushed the flakes-packagekit branch 2 times, most recently from 6bb1e3b to 714abd9 Compare February 9, 2022 01:22

packagekit: use Nix backend

92a6ad8

Fixes NixOS#21230 Use Nix backend for packagekit. Updates to version with my Nix backend for PackageKit.

matthewbauer force-pushed the flakes-packagekit branch from 714abd9 to 92a6ad8 Compare February 9, 2022 01:24

jtojnar approved these changes Feb 9, 2022

View reviewed changes

matthewbauer merged commit 7ca33e5 into NixOS:master Feb 9, 2022

davidak mentioned this pull request Mar 18, 2023

Submit to GNOME Software as a plugin snowfallorg/nix-software-center#16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

packagekit: update to flakes branch #94055

packagekit: update to flakes branch #94055

matthewbauer commented Jul 28, 2020 •

edited

nixos-discourse commented Jul 28, 2020

worldofpeace commented Jul 28, 2020 •

edited

worldofpeace commented Jul 28, 2020 •

edited

worldofpeace commented Jul 28, 2020

matthewbauer commented Jul 28, 2020

matthewbauer commented Jul 29, 2020

wmertens commented Mar 9, 2021

matthewbauer commented Mar 9, 2021

stale bot commented Sep 6, 2021

lapp0 commented Nov 21, 2021 •

edited

matthewbauer commented Feb 8, 2022

davidak commented Feb 8, 2022

jtojnar Feb 8, 2022

wmertens Feb 8, 2022

jtojnar Feb 8, 2022

jtojnar commented Feb 9, 2022 •

edited

matthewbauer commented Feb 9, 2022

jtojnar commented Feb 9, 2022

jtojnar left a comment

thufschmitt commented Feb 28, 2022

jtojnar commented Feb 28, 2022 •

edited

packagekit: update to flakes branch #94055

packagekit: update to flakes branch #94055

Conversation

matthewbauer commented Jul 28, 2020 • edited

Motivation for this change

Things done

nixos-discourse commented Jul 28, 2020

worldofpeace commented Jul 28, 2020 • edited

worldofpeace commented Jul 28, 2020 • edited

worldofpeace commented Jul 28, 2020

matthewbauer commented Jul 28, 2020

matthewbauer commented Jul 29, 2020

wmertens commented Mar 9, 2021

matthewbauer commented Mar 9, 2021

stale bot commented Sep 6, 2021

lapp0 commented Nov 21, 2021 • edited

matthewbauer commented Feb 8, 2022

davidak commented Feb 8, 2022

jtojnar Feb 8, 2022

Choose a reason for hiding this comment

wmertens Feb 8, 2022

Choose a reason for hiding this comment

jtojnar Feb 8, 2022

Choose a reason for hiding this comment

jtojnar commented Feb 9, 2022 • edited

matthewbauer commented Feb 9, 2022

jtojnar commented Feb 9, 2022

jtojnar left a comment

Choose a reason for hiding this comment

thufschmitt commented Feb 28, 2022

jtojnar commented Feb 28, 2022 • edited

matthewbauer commented Jul 28, 2020 •

edited

worldofpeace commented Jul 28, 2020 •

edited

worldofpeace commented Jul 28, 2020 •

edited

lapp0 commented Nov 21, 2021 •

edited

jtojnar commented Feb 9, 2022 •

edited

jtojnar commented Feb 28, 2022 •

edited