Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zabbix*: replace extraConfig option with settings option #94043

Merged
merged 3 commits into from Aug 4, 2020
Merged

nixos/zabbix*: replace extraConfig option with settings option #94043

merged 3 commits into from Aug 4, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 28, 2020 •
edited

Motivation for this change

Defining configuration files via attribute sets is better than defining configuration files via strings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse force-pushed the zabbix-settings branch 2 times, most recently from 37512b0 to 22929b8 Compare July 28, 2020 01:27
@aanderse aanderse marked this pull request as ready for review July 28, 2020 12:26
@aanderse
Copy link
Member Author

I have tested that the generated configuration files are equivalent for all three services using production configuration.

@aanderse
Copy link
Member Author

@GrahamcOfBorg eval

@aanderse
Copy link
Member Author

aanderse commented Aug 1, 2020

ping @PsyanticY

@aanderse aanderse merged commit 620e154 into NixOS:master Aug 4, 2020
@aanderse aanderse deleted the zabbix-settings branch August 4, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@mmahut mmahut Awaiting requested review from mmahut

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aanderse