Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncdns: fix patch extension #94057

Merged
merged 1 commit into from Jul 28, 2020
Merged

ncdns: fix patch extension #94057

merged 1 commit into from Jul 28, 2020

Conversation

lf-
Copy link
Member

@lf- lf- commented Jul 28, 2020

Motivation for this change

The incorrect extension (stuff that is not nix source in a .nix file) was confusing my code search tool that parses all .nix files in the nixpkgs tree.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lf-
ncdns: fix patch extension
231e74d 
The incorrect extension was confusing my code search tool.
@ofborg ofborg bot requested a review from rnhmjoj July 28, 2020 06:28
rnhmjoj
rnhmjoj approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a typo, thank you.

@rnhmjoj rnhmjoj merged commit c36525e into NixOS:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lf- @rnhmjoj @Janik-Haag