Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tanka: add bash completion #95106

Merged
merged 1 commit into from Aug 21, 2020
Merged

tanka: add bash completion #95106

merged 1 commit into from Aug 21, 2020

Conversation

mikefaille
Copy link
Contributor

Motivation for this change

As suggested here, adding bash completion should be great for Tanka

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 11, 2020 00:19
@mikefaille
Copy link
Contributor Author

I tried the UI to commit the suggestion but it creates a new commit. Could we squash it via the UI or should I do it ?

@danieldk
Copy link
Contributor

I tried the UI to commit the suggestion but it creates a new commit. Could we squash it via the UI or should I do it ?

Could you squash them?

@mikefaille
Copy link
Contributor Author

mikefaille commented Aug 21, 2020 •
edited

I tried the UI to commit the suggestion but it creates a new commit. Could we squash it via the UI or should I do it ?

Could you squash them?

Done

danieldk
danieldk approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95106 1

1 package built:
- tanka

Tested bash completion ✔️

@danieldk danieldk merged commit 117c059 into NixOS:master Aug 21, 2020
@danieldk
Copy link
Contributor

Thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikefaille @danieldk