Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandoc-plantuml-filter: init at 0.1.2 #95143

Merged
merged 1 commit into from Aug 21, 2020
Merged

pandoc-plantuml-filter: init at 0.1.2 #95143

merged 1 commit into from Aug 21, 2020

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Aug 11, 2020 •
edited

Motivation for this change

Adds the Pandoc filter which converts PlantUML code blocks to PlantUML images. Pretty useful!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

CMCDragonkai commented Aug 11, 2020 •
edited

I've tested this with:

pandoc -V geometry:margin=1in 'test.md' -o 'test.pdf' --filter pandoc-plantuml

It creates a directory called plantuml-images.

Note that plantuml has to be in the PATH to use this, but that's an expected thing since you need both pandoc and plantuml to use this filter.

I'm not sure how to represent "peer" dependencies in Nix.

@CMCDragonkai
Copy link
Member Author

I guess that makes this closer to a python application, not module since there's nothing to import. How to switch to that?

@CMCDragonkai
Copy link
Member Author

Put it next to pandoc-imagine. This is ready to be merged.

@CMCDragonkai
Copy link
Member Author

@jonringer

jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/95143
1 package built:
pandoc-plantuml-filter

@jonringer jonringer merged commit 4a87da1 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CMCDragonkai @jonringer