Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: ffmpeg_3 -> ffmpeg #95113

Merged
merged 1 commit into from Aug 26, 2020
Merged

firefox-bin: ffmpeg_3 -> ffmpeg #95113

merged 1 commit into from Aug 26, 2020

Conversation

samuelgrf
Copy link
Member

Motivation for this change

This makes the ffmpeg version in firefox-bin consistent with the firefox wrapper.

Things done

Tested video playback in all firefox*-bin packages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from taku0 August 11, 2020 01:47
@Atemu Atemu requested a review from adisbladis August 25, 2020 12:28
@adisbladis adisbladis merged commit 5f464fc into NixOS:master Aug 26, 2020
@samuelgrf samuelgrf deleted the update/firefox-bin-ffmpeg branch March 5, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen FlorianFranzen approved these changes

@taku0 taku0 taku0 approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samuelgrf @FlorianFranzen @taku0 @adisbladis