Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove obsolete attribute goPackagePath in buildGoModule derivations #95092

Merged
merged 1 commit into from Aug 11, 2020
Merged

treewide: remove obsolete attribute goPackagePath in buildGoModule derivations #95092

merged 1 commit into from Aug 11, 2020

Conversation

timstott
Copy link
Contributor

@timstott timstott commented Aug 10, 2020 •
edited

Motivation for this change

The buildGoModule infrastructure does not make use of goPackagePath, it is a residue from buildGoPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timstott timstott changed the title Cleanup: delete obselete attribute goPackagePath where buildGoModule is used Cleanup: remove obselete attribute goPackagePath in buildGoModule derivations Aug 10, 2020
@zimbatm

This comment has been minimized.

Sign in to view
@zimbatm

This comment has been minimized.

Sign in to view
@timstott timstott force-pushed the delete-gopackagepath-attribute-in-go-modules branch 2 times, most recently from 4e38d27 to 7a7a5e7 Compare August 10, 2020 17:19
@zimbatm
Copy link
Member

zimbatm commented Aug 10, 2020 •
edited

Result of nixpkgs-review pr 95092 1

2 packages failed to build:
- vimPlugins.YouCompleteMe
- ycmd
26 packages built:
- age
- caddy
- coredns
- drone
- godef
- gomodifytags
- gomuks
- gopkgs
- gosec
- hcloud
- iamy
- kapow
- kind
- kube3d
- matterbridge
- oneshot
- reftools
- sensu-go-agent
- sensu-go-backend
- sensu-go-cli
- shadowfox
- styx
- tailscale
- telegraf
- vimPlugins.vim-go
- zsh-history
error message: 
warning: unknown setting 'experimental-features'
error: --- Error --- nix-daemon
builder for '/nix/store/yvxz7pvrr0vgr3iav8iv14ifh2mx7l2a-racerd-unstable-2019-09-02.drv' failed with exit code 101; last 10 log lines:
      = note: consider migrating to the new asm! syntax specified in RFC 2873
      = note: alternatively, switch to llvm_asm! to keep your code working as it is
  
  error: aborting due to 2 previous errors
  
  error: could not compile `parking_lot`.
  
  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/v3lr5z3s2v1zsx5phzlhdwk2wshg0rn7-ycmd-2020-02-22.drv' failed to build
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/ih99wk8zbn7fwa223difq1b71nnzg7y4-vimplugin-YouCompleteMe-2020-07-21.drv' failed to build

@zimbatm zimbatm mentioned this pull request Aug 10, 2020
Merged
10 tasks
@timstott timstott force-pushed the delete-gopackagepath-attribute-in-go-modules branch from 7a7a5e7 to 64c64b6 Compare August 10, 2020 17:49
@timstott timstott changed the title Cleanup: remove obselete attribute goPackagePath in buildGoModule derivations tree-wide: remove obsolete attribute goPackagePath in buildGoModule derivations Aug 10, 2020
@timstott
Copy link
Contributor Author

Result of nixpkgs-review pr 95092 1

28 packages built:
- age
- caddy
- coredns
- drone
- godef
- gomodifytags
- gomuks
- gopkgs
- gosec
- hcloud
- iamy
- kapow
- kind
- kube3d
- matterbridge
- oneshot
- reftools
- sensu-go-agent
- sensu-go-backend
- sensu-go-cli
- shadowfox
- styx
- tailscale
- telegraf
- vimPlugins.YouCompleteMe
- vimPlugins.vim-go
- ycmd
- zsh-history

zimbatm
zimbatm approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@timstott timstott force-pushed the delete-gopackagepath-attribute-in-go-modules branch from 39b51ba to 7574868 Compare August 11, 2020 17:32
@timstott timstott marked this pull request as ready for review August 11, 2020 17:32
@timstott
treewide: remove obsolete attribute goPackagePath in buildGoModule de…
23bbb89 
…rivations

The buildGoModule infrastructure does not make use of goPackagePath it is a residue from buildGoPackage.
@timstott timstott force-pushed the delete-gopackagepath-attribute-in-go-modules branch from 7574868 to 23bbb89 Compare August 11, 2020 17:37
@timstott timstott changed the title tree-wide: remove obsolete attribute goPackagePath in buildGoModule derivations treewide: remove obsolete attribute goPackagePath in buildGoModule derivations Aug 11, 2020
@timstott
Copy link
Contributor Author

Result of nixpkgs-review pr 95092 1

37 packages built:
- age
- caddy
- clash
- coredns
- drone
- drone-cli
- gitAndTools.git-bug
- godef
- gomodifytags
- gomuks
- gopkgs
- gosec
- hcloud
- iamy
- kapow
- kind
- kube3d
- kubeprompt
- matterbridge
- mkcert
- nix-build-uncached
- oneshot
- reftools
- sensu-go-agent
- sensu-go-backend
- sensu-go-cli
- shadowfox
- sourcehut.buildsrht
- sourcehut.gitsrht
- sourcehut.hgsrht
- styx
- tailscale
- telegraf
- vimPlugins.YouCompleteMe
- vimPlugins.vim-go
- ycmd
- zsh-history

@timstott
Copy link
Contributor Author

This is ready to be merged @zimbatm 🎉

@zimbatm zimbatm merged commit ba7c089 into NixOS:master Aug 11, 2020
@zimbatm
Copy link
Member

zimbatm commented Aug 11, 2020

thanks for your contribution!

@zowoq zowoq mentioned this pull request Aug 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timstott @zimbatm