Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcstar: init at 1.7.2 + perl package dependencies #83021

Merged
merged 1 commit into from Aug 10, 2020
Merged

gcstar: init at 1.7.2 + perl package dependencies #83021

merged 1 commit into from Aug 10, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 20, 2020 •
edited

Motivation for this change

This is my first package made from scratch. So please point out eventual beginner errors. Thanks

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

When I run it, after selecting a collection type, the UI stays frozen:

***   undef is not of type Gtk2::Widget at /nix/store/vgx575rq53c02vvryw8k4pzxvhdv2689-gcstar-1.7.1/bin/../lib/gcstar/GCGraphicComponents/GCBaseWidgets.pm line 1013.

Maybe you need wrapGappsHook ?

@dasj19
Copy link
Contributor Author

dasj19 commented Mar 21, 2020 •
edited

@symphorien I only made it fail selecting board games or music collection type so far... which type did you select?

Edit: I investigated a bit and it seems the error happens because of a missing dependency perl-gtk2 which is not in nix yet... so I'll try to package that as well

@symphorien
Copy link
Member

Wine

@dasj19 dasj19 changed the title gcstar: 1.7.1 gcstar: 1.7.2 + perl package dependencies Mar 23, 2020
@dasj19
Copy link
Contributor Author

dasj19 commented Mar 23, 2020

@symphorien I found that the code from original gcstar project appears to no longer be maintained but someone continued the work other place: https://gitlab.com/Kerenoc/GCstar/

So I applied those updates and fixed all the perl package dependencies... and now it should work with all types of collections

@dasj19 dasj19 changed the title gcstar: 1.7.2 + perl package dependencies gcstar: init at 1.7.2 + perl package dependencies Mar 23, 2020
@symphorien
Copy link
Member

Yes now it works.

I think you can simplify the derivation by using patchShebangs (it is automatically ran after the installPhase) and fetchFromGitHub, which unpacks the source for you.

@dasj19
Copy link
Contributor Author

dasj19 commented Mar 24, 2020

@symphorien thanks for approving.. I also fixed the doCheck issues for the perl modules

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python 6.topic: vim labels Jul 4, 2020
@dasj19
Copy link
Contributor Author

dasj19 commented Jul 13, 2020

@jtojnar Can we get this old PR merged?

jtojnar
jtojnar reviewed Jul 13, 2020
View reviewed changes
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/gcstar/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@dasj19 dasj19 force-pushed the gcstar-1.7.1 branch 2 times, most recently from f4c8380 to af82865 Compare July 13, 2020 15:53
@dasj19
Copy link
Contributor Author

dasj19 commented Aug 10, 2020

I have been using this for weeks, found no issue with the software... can we release it?

@jtojnar jtojnar merged commit d81afb3 into NixOS:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@symphorien symphorien symphorien approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@alyssais alyssais Awaiting requested review from alyssais

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@mmahut mmahut Awaiting requested review from mmahut

@peti peti Awaiting requested review from peti

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasj19 @symphorien @jonringer @jtojnar