Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reno: 2.3.2 -> 3.1.0 #95118

Merged
merged 1 commit into from Aug 11, 2020
Merged

reno: 2.3.2 -> 3.1.0 #95118

merged 1 commit into from Aug 11, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Reno release notes manager was 3 years out of date, and didn't work anyways.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

cc maintainer @guillaumekoenig

@guillaumekoenig
Copy link
Contributor

I'd recommend putting yourself as maintainer.

@drewrisinger
reno: 2.3.2 -> 3.1.0
ccb6b07 
Fix execution, and upgrade to latest version.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build reno

@bhipple
Copy link
Contributor

bhipple commented Aug 11, 2020

Looks great, thanks for the big update!

@bhipple
Copy link
Contributor

bhipple commented Aug 11, 2020

Result of nixpkgs-review pr 95118 1

1 package built:
- reno

@bhipple bhipple merged commit 0ea35cf into NixOS:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @guillaumekoenig @bhipple